Remove_redundant_surfaces() for identical planes with different a, b, c, d (proportional)

Development
1

Hello group,

If my observation is correct, I noticed that remove_redundant_surfaces(), or remove_surfs in the legacy version, does not merge identical surfaces with different parameters. For example, x+y+z=1 and 2x+2y+2z=2 are NOT merged. Such identical planes with different a, b, c, d do exist in OpenMC modeling. For example, when from_points and rotation are used.

Are there any reasons to leave such surfaces unmerged on purpose? If not, would such improvements be needed? I’d be happy to make the change.

Xinyan

2

Thanks for the notice @wxinyan.

The “Surface.normalize” method should be accounting for this. Though it may be that it did not always do this.

Can you share what version/git SHA of OpenMC you’re working with?

1 Like
3

Thank you for the information. That’s helpful! I am using 0.15.1.